Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove unecessary copy operation on Camera #1708

Merged
merged 2 commits into from
Jun 7, 2022
Merged

refactor: Remove unecessary copy operation on Camera #1708

merged 2 commits into from
Jun 7, 2022

Conversation

luanpotter
Copy link
Member

Description

Turns out we have two ways of accessing camera position: position is for the outside, it creates a copy. This method was already non-static and accessing _position via this, so I just removed both parameters to make it less confusing.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@luanpotter luanpotter requested a review from a team June 7, 2022 09:28
@spydon spydon requested a review from st-pasha June 7, 2022 09:44
@luanpotter luanpotter merged commit 94cc115 into main Jun 7, 2022
@luanpotter luanpotter deleted the luan.camera-fix branch June 7, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@renancaraujo renancaraujo renancaraujo approved these changes

@st-pasha st-pasha Awaiting requested review from st-pasha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luanpotter @spydon @renancaraujo